Patch for common_test (R12B-0)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch for common_test (R12B-0)

Sergei Golovan-4
Hi!

Appears that common_test application fails to build on some
architectures (in Debian Linux) because rx library is built without
-fPIC option (so, it can't be used in a shared library).

Also, headrs string.h and stdio.h aren't included which gives warnings
about incompatible implicit function declarations.

The attached patch fixes both issues. It also replaces -fpic by -fPIC
(-fPIC is more general) and adds explicit -lc to erl_rx_driver build
options (it's encouraged by Debian policy, but feel free to remove it
if it's not necessary).

--
Sergei Golovan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rx.diff
Type: application/octet-stream
Size: 1683 bytes
Desc: not available
URL: <http://erlang.org/pipermail/erlang-patches/attachments/20071215/542f7acb/attachment.obj>

Reply | Threaded
Open this post in threaded view
|

Patch for common_test (R12B-0)

Peter Andersson-2

Hi Sergei,

Thank you very much for the info and the patch!

Best regards,
Peter


Sergei Golovan wrote:

> Hi!
>
> Appears that common_test application fails to build on some
> architectures (in Debian Linux) because rx library is built without
> -fPIC option (so, it can't be used in a shared library).
>
> Also, headrs string.h and stdio.h aren't included which gives warnings
> about incompatible implicit function declarations.
>
> The attached patch fixes both issues. It also replaces -fpic by -fPIC
> (-fPIC is more general) and adds explicit -lc to erl_rx_driver build
> options (it's encouraged by Debian policy, but feel free to remove it
> if it's not necessary).
>
>  
> ------------------------------------------------------------------------
>
> _______________________________________________
> erlang-patches mailing list
> erlang-patches
> http://www.erlang.org/mailman/listinfo/erlang-patches