What is the unit for max_frame_size(WebSocket) on Cowboy?

[by]

Hello List,

As stated in the subject, anyone knew the unit for max_frame_size(WebSocket) on Cowboy?

For convention, this should be “byte". Just want to make sure.

I checked with https://ninenines.eu/docs/en/cowboy/2.6/manual/cowboy_websocket/ but no explicit word specify this.

Best Regards,

Yao

_______________________________________________
erlang-questions mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-questions

[Loïc Hoguin-3]

Yes bytes. Every data sizes in Cowboy are bytes. Please send a patch to
the docs.

https://github.com/ninenines/cowboy/blob/master/doc/src/manual/cowboy_websocket.asciidoc

On 20/05/2019 05:16, by wrote:

> Hello List,
>
> As stated in the subject, anyone knew the unit
> for max_frame_size(WebSocket) on Cowboy?
>
> For convention, this should be “byte". Just want to make sure.
> I checked with
> https://ninenines.eu/docs/en/cowboy/2.6/manual/cowboy_websocket/ but no
> explicit word specify this.
>
> Best Regards,
> Yao
>
> _______________________________________________
> erlang-questions mailing list
> [hidden email]
> http://erlang.org/mailman/listinfo/erlang-questions
>

--
Loïc Hoguin
https://ninenines.eu
_______________________________________________
erlang-questions mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-questions

[by]

I created a pull request for it: https://github.com/ninenines/cowboy/pull/1377

在 2019年5月20日，15:17，Loïc Hoguin <[hidden email]> 写道：

Yes bytes. Every data sizes in Cowboy are bytes. Please send a patch to the docs.

https://github.com/ninenines/cowboy/blob/master/doc/src/manual/cowboy_websocket.asciidoc

On 20/05/2019 05:16, by wrote:

Hello List,
As stated in the subject, anyone knew the unit for max_frame_size(WebSocket) on Cowboy?
For convention, this should be “byte". Just want to make sure.
I checked with https://ninenines.eu/docs/en/cowboy/2.6/manual/cowboy_websocket/ but no explicit word specify this.
Best Regards,
Yao
_______________________________________________
erlang-questions mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-questions

--
Loïc Hoguin
https://ninenines.eu

_______________________________________________
erlang-questions mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-questions