[jinterface] fix regression of 4390e43558 writing small compressed values

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[jinterface] fix regression of 4390e43558 writing small compressed values

Nico Kruber-5
Hi,
we came across a regression in the JInterface code which slipped in for Erlang
17.5 iirc. It prevents the Java code to compress e.g. the string "{}" the way,
erlang:term_to_binary("{}", [compressed]) does. The patch is rather simple and
reverts the changes of 4390e43558 to the OtpOutputStream class and adds
appropriate test cases to prevent further breakages.


https://github.com/erlang/otp/compare/maint...NicoK:maint
https://github.com/erlang/otp/compare/maint...NicoK:maint.patch




Nico
_______________________________________________
erlang-patches mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-patches

signature.asc (188 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [jinterface] fix regression of 4390e43558 writing small compressed values

Vlad Dumitrescu-2
Hi Nico,

Yes, indeed, that slipped through. I'm sorry if it caused you any inconvenience.

Please open a pull request with that change.

regards,
Vlad


On Mon, Nov 9, 2015 at 8:50 PM, Nico Kruber <[hidden email]> wrote:
Hi,
we came across a regression in the JInterface code which slipped in for Erlang
17.5 iirc. It prevents the Java code to compress e.g. the string "{}" the way,
erlang:term_to_binary("{}", [compressed]) does. The patch is rather simple and
reverts the changes of 4390e43558 to the OtpOutputStream class and adds
appropriate test cases to prevent further breakages.


https://github.com/erlang/otp/compare/maint...NicoK:maint
https://github.com/erlang/otp/compare/maint...NicoK:maint.patch




Nico

_______________________________________________
erlang-patches mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-patches



_______________________________________________
erlang-patches mailing list
[hidden email]
http://erlang.org/mailman/listinfo/erlang-patches